pylint multiple files

fedora-infra · Jun 20, 2023 · b4d82a4 · b4d82a4
1 parent 159602e
commit b4d82a4
Show file tree

Hide file tree

Showing 20 changed files with 126 additions and 48 deletions.
diff --git a/anitya/db/migrations/versions/136d119ab015_rename_project_latest_known_cursor_to_.py b/anitya/db/migrations/versions/136d119ab015_rename_project_latest_known_cursor_to_.py
@@ -8,18 +8,20 @@
 from alembic import op
 
 # revision identifiers, used by Alembic.
-revision = "136d119ab015"
-down_revision = "92a2e9eba0a7"
+revision = "136d119ab015"  # pylint: disable=C0103
+down_revision = "92a2e9eba0a7"  # pylint: disable=C0103
 
 
 def upgrade():
+    """Upgrade"""
     with op.batch_alter_table("projects") as batch_op:
         batch_op.alter_column(
             "latest_known_cursor", new_column_name="latest_version_cursor"
         )
 
 
 def downgrade():
+    """Downgrade"""
     with op.batch_alter_table("projects") as batch_op:
         batch_op.alter_column(
             "latest_version_cursor", new_column_name="latest_known_cursor"

diff --git a/anitya/db/migrations/versions/16aa7da2764c_add_projectversion_commit_url.py b/anitya/db/migrations/versions/16aa7da2764c_add_projectversion_commit_url.py
@@ -14,12 +14,14 @@
 
 
 def upgrade():
+    """Upgrade"""
     op.add_column(
         "projects_versions",
         sa.Column("commit_url", sa.String(length=200), nullable=True),
     )
 
 
 def downgrade():
+    """Downgrade"""
     with op.batch_alter_table("projects_versions") as batch_op:
         batch_op.drop_column("commit_url")
diff --git a/anitya/db/migrations/versions/3fae8239eeec_add_an_api_token_table.py b/anitya/db/migrations/versions/3fae8239eeec_add_an_api_token_table.py
@@ -34,7 +34,7 @@
 down_revision = "feeaa70ead67"
 
 
-class GUID(TypeDecorator):
+class GUID(TypeDecorator):  # pylint: disable=W0223
     """
     Platform-independent GUID type.
 
@@ -79,10 +79,10 @@ def process_bind_param(self, value, dialect):
             return str(value)
         else:
             if not isinstance(value, uuid.UUID):
-                return "%.32x" % uuid.UUID(value).int
+                return f"{uuid.UUID(value).int:032x}"
             else:
                 # hexstring
-                return "%.32x" % value.int
+                return f"{value.int:032x}"
 
     def process_result_value(self, value, dialect):
         """

diff --git a/anitya/db/migrations/versions/921c612ba0da_model_upstream_ecosystems.py b/anitya/db/migrations/versions/921c612ba0da_model_upstream_ecosystems.py
@@ -15,6 +15,7 @@
 
 
 def upgrade():
+    """Upgrade"""
     op.add_column(
         "projects", sa.Column("ecosystem_name", sa.String(length=200), nullable=True)
     )
@@ -33,6 +34,7 @@ def upgrade():
 
 
 def downgrade():
+    """Downgrade"""
     op.drop_constraint("FK_ECOSYSTEM_FOR_PROJECT", "projects", type_="foreignkey")
     op.drop_constraint("UNIQ_PROJECT_NAME_PER_ECOSYSTEM", "projects", type_="unique")
     op.drop_column("projects", "ecosystem_name")
diff --git a/anitya/db/migrations/versions/92a2e9eba0a7_add_project_latest_known_cursor.py b/anitya/db/migrations/versions/92a2e9eba0a7_add_project_latest_known_cursor.py
@@ -14,12 +14,14 @@
 
 
 def upgrade():
+    """Upgrade"""
     op.add_column(
         "projects",
         sa.Column("latest_known_cursor", sa.String(length=200), nullable=True),
     )
 
 
 def downgrade():
+    """Downgrade"""
     with op.batch_alter_table("projects") as batch_op:
         batch_op.drop_column("latest_known_cursor")
diff --git a/anitya/db/migrations/versions/9c29da0af3af_populate_ecosystem_data.py b/anitya/db/migrations/versions/9c29da0af3af_populate_ecosystem_data.py
@@ -14,6 +14,7 @@
 
 
 def upgrade():
+    """Upgrade"""
     # We use a subquery instead of an UPDATE FROM with a table join
     # due to the fact that SQLite doesn't allow joins in update statements
     op.execute(
@@ -32,6 +33,7 @@ def upgrade():
 
 
 def downgrade():
+    """Downgrade"""
     # Do nothing on downgrade - column removal will be handled by previous
     # revision
     pass
diff --git a/anitya/db/migrations/versions/a52d2fe99d4f_users.py b/anitya/db/migrations/versions/a52d2fe99d4f_users.py
@@ -17,7 +17,7 @@
 down_revision = "8040ef9a9dda"
 
 
-class GUID(TypeDecorator):
+class GUID(TypeDecorator):  # pylint: disable=W0223
     """
     Platform-independent GUID type.
 
@@ -62,10 +62,10 @@ def process_bind_param(self, value, dialect):
             return str(value)
         else:
             if not isinstance(value, uuid.UUID):
-                return "%.32x" % uuid.UUID(value).int
+                return f"{uuid.UUID(value).int:032x}"
             else:
                 # hexstring
-                return "%.32x" % value.int
+                return f"{value.int:032x}"
 
     def process_result_value(self, value, dialect):
         """

diff --git a/anitya/db/migrations/versions/ac10bf3f974c_.py b/anitya/db/migrations/versions/ac10bf3f974c_.py
@@ -11,8 +11,10 @@
 
 
 def upgrade():
+    """Upgrade"""
     pass
 
 
 def downgrade():
+    """Downgrade"""
     pass
diff --git a/anitya/db/migrations/versions/b9201d816075_remove_the_backends_and_ecosystems_.py b/anitya/db/migrations/versions/b9201d816075_remove_the_backends_and_ecosystems_.py
@@ -40,7 +40,7 @@ def downgrade():
     # We have to populate the backends table before we can add the ecosystems
     # table with its foreign key constraint.
     for backend in plugins.BACKEND_PLUGINS.get_plugins():
-        op.execute("INSERT INTO backends (name) VALUES ('{}');".format(backend.name))
+        op.execute(f"INSERT INTO backends (name) VALUES ('{backend.name}');")
 
     op.create_table(
         "ecosystems",
@@ -65,11 +65,9 @@ def downgrade():
     )
     for ecosystem in plugins.ECOSYSTEM_PLUGINS.get_plugins():
         op.execute(
-            """
+            f"""
             INSERT INTO ecosystems (name, default_backend_name)
-            VALUES ('{name}', '{default}');""".format(
-                name=ecosystem.name, default=ecosystem.default_backend
-            )
+            VALUES ('{ecosystem.name}', '{ecosystem.default_backend}');"""
         )
 
     op.create_foreign_key(

diff --git a/anitya/db/migrations/versions/feeaa70ead67_social_authentication_table.py b/anitya/db/migrations/versions/feeaa70ead67_social_authentication_table.py
@@ -35,7 +35,7 @@
 down_revision = "a52d2fe99d4f"
 
 
-class GUID(TypeDecorator):
+class GUID(TypeDecorator):  # pylint: disable=W0223
     """
     Platform-independent GUID type.
 
@@ -80,10 +80,10 @@ def process_bind_param(self, value, dialect):
             return str(value)
         else:
             if not isinstance(value, uuid.UUID):
-                return "%.32x" % uuid.UUID(value).int
+                return f"{uuid.UUID(value).int:032x}"
             else:
                 # hexstring
-                return "%.32x" % value.int
+                return f"{value.int:032x}"
 
     def process_result_value(self, value, dialect):
         """

diff --git a/anitya/lib/backends/cpan.py b/anitya/lib/backends/cpan.py
@@ -44,7 +44,7 @@ def get_version_url(cls, project):
         Returns:
             str: url used for version checking
         """
-        url = "https://metacpan.org/release/%(name)s/" % {"name": project.name}
+        url = f"https://metacpan.org/release/{project.name}/"
 
         return url
 
@@ -80,19 +80,19 @@ def check_feed(cls):
 
         try:
             response = cls.call_url(url)
-        except Exception:  # pragma: no cover
-            raise AnityaPluginException("Could not contact %s" % url)
+        except Exception as exc:  # pragma: no cover
+            raise AnityaPluginException(f"Could not contact {url}") from exc
 
         try:
             root = ET.fromstring(response.text)
-        except ET.ParseError:
-            raise AnityaPluginException("No XML returned by %s" % url)
+        except ET.ParseError as exc:
+            raise AnityaPluginException(f"No XML returned by {url}") from exc
 
         for item in root.iter(tag="{http://purl.org/rss/1.0/}item"):
             title = item.find("{http://purl.org/rss/1.0/}title")
             try:
                 name, version = title.text.rsplit("-", 1)
             except ValueError:
                 _log.info("Unable to parse CPAN package %s into a name and version")
-            homepage = "https://metacpan.org/release/%s/" % name
+            homepage = f"https://metacpan.org/release/{name}/"
             yield name, homepage, cls.name, version
diff --git a/anitya/lib/backends/drupal6.py b/anitya/lib/backends/drupal6.py
@@ -50,9 +50,7 @@ def get_version_url(cls, project):
         if "-" in project.name:
             name = project.name.replace("-", "_")
 
-        url_template = "https://updates.drupal.org/release-history/" "%(name)s/6.x"
-
-        url = url_template % {"name": name}
+        url = f"https://updates.drupal.org/release-history/{name}/6.x"
 
         return url
 
@@ -84,3 +82,25 @@ def get_versions(cls, project):
             raise err
 
         return versions
+
+    @classmethod
+    def check_feed(cls):  # pragma: no cover
+        """Method called to retrieve the latest uploads to a given backend,
+        via, for example, RSS or an API.
+
+        Not all backends may support this.  It can be used to look for updates
+        much more quickly than scanning all known projects.
+
+        Returns:
+            :obj:`list`: A list of 4-tuples, containing the project name, homepage, the
+            backend, and the version.
+
+        Raises:
+            AnityaPluginException: A
+                :obj:`anitya.lib.exceptions.AnityaPluginException` exception
+                when the versions cannot be retrieved correctly
+            NotImplementedError: If backend does not
+                support batch updates.
+
+        """
+        raise NotImplementedError()
diff --git a/anitya/lib/backends/packagist.py b/anitya/lib/backends/packagist.py
@@ -66,23 +66,23 @@ def get_versions(cls, project):
         url = cls.get_version_url(project)
         if not url:
             raise AnityaPluginException(
-                "Project {} is not correctly set up.".format(project.name)
+                f"Project {project.name} is not correctly set up."
             )
 
         last_change = project.get_time_last_created_version()
         try:
             req = cls.call_url(url, last_change=last_change)
-        except Exception:  # pragma: no cover
-            raise AnityaPluginException("Could not contact %s" % url)
+        except Exception as exc:  # pragma: no cover
+            raise AnityaPluginException(f"Could not contact {url}") from exc
 
         # Not modified
         if req.status_code == 304:
             return []
 
         try:
             data = req.json()
-        except Exception:  # pragma: no cover
-            raise AnityaPluginException("No JSON returned by %s" % url)
+        except Exception as exc:  # pragma: no cover
+            raise AnityaPluginException(f"No JSON returned by {url}") from exc
 
         if "package" in data and "versions" in data["package"]:
             # Filter retrieved versions
@@ -94,4 +94,26 @@ def get_versions(cls, project):
         elif "status" in data and data["status"] == "error" and "message" in data:
             raise AnityaPluginException(data["message"])
         else:
-            raise AnityaPluginException("Invalid JSON returned by %s" % url)
+            raise AnityaPluginException(f"Invalid JSON returned by {url}")
+
+    @classmethod
+    def check_feed(cls):  # pragma: no cover
+        """Method called to retrieve the latest uploads to a given backend,
+        via, for example, RSS or an API.
+
+        Not all backends may support this.  It can be used to look for updates
+        much more quickly than scanning all known projects.
+
+        Returns:
+            :obj:`list`: A list of 4-tuples, containing the project name, homepage, the
+            backend, and the version.
+
+        Raises:
+            AnityaPluginException: A
+                :obj:`anitya.lib.exceptions.AnityaPluginException` exception
+                when the versions cannot be retrieved correctly
+            NotImplementedError: If backend does not
+                support batch updates.
+
+        """
+        raise NotImplementedError()
diff --git a/anitya/lib/backends/pecl.py b/anitya/lib/backends/pecl.py
@@ -18,8 +18,8 @@ def _get_versions(url):
     """Retrieve the versions for the provided url."""
     try:
         req = PeclBackend.call_url(url)
-    except Exception:  # pragma: no cover
-        raise AnityaPluginException("Could not contact %s" % url)
+    except Exception as exc:  # pragma: no cover
+        raise AnityaPluginException(f"Could not contact {url}") from exc
 
     data = req.text
     versions = []
@@ -101,9 +101,7 @@ def get_versions(cls, project):
         versions = _get_versions(url)
 
         if not versions:
-            raise AnityaPluginException(
-                "No versions found for %s" % project.name.lower()
-            )
+            raise AnityaPluginException(f"No versions found for {project.name.lower()}")
 
         # Filter retrieved versions
         filtered_versions = BaseBackend.filter_versions(
@@ -122,18 +120,18 @@ def check_feed(cls):
 
         try:
             response = cls.call_url(url)
-        except Exception:  # pragma: no cover
-            raise AnityaPluginException("Could not contact %s" % url)
+        except Exception as exc:  # pragma: no cover
+            raise AnityaPluginException(f"Could not contact {url}") from exc
 
         try:
             parser = xml2dict.XML2Dict()
             data = parser.fromstring(response.text)
-        except Exception:  # pragma: no cover
-            raise AnityaPluginException("No XML returned by %s" % url)
+        except Exception as exc:  # pragma: no cover
+            raise AnityaPluginException(f"No XML returned by {url}") from exc
 
         items = data["RDF"]["item"]
         for entry in items:
             title = entry["title"]["value"]
             name, version = title.rsplit(None, 1)
-            homepage = "https://pecl.php.net/package/%s" % name
+            homepage = f"https://pecl.php.net/package/{name}"
             yield name, homepage, cls.name, version
diff --git a/anitya/lib/backends/sourceforge.py b/anitya/lib/backends/sourceforge.py
@@ -63,3 +63,25 @@ def get_versions(cls, project):
         regex = REGEX % {"name": project.name.replace("+", r"\+")}
 
         return get_versions_by_regex(url, regex, project)
+
+    @classmethod
+    def check_feed(cls):  # pragma: no cover
+        """Method called to retrieve the latest uploads to a given backend,
+        via, for example, RSS or an API.
+
+        Not all backends may support this.  It can be used to look for updates
+        much more quickly than scanning all known projects.
+
+        Returns:
+            :obj:`list`: A list of 4-tuples, containing the project name, homepage, the
+            backend, and the version.
+
+        Raises:
+            AnityaPluginException: A
+                :obj:`anitya.lib.exceptions.AnityaPluginException` exception
+                when the versions cannot be retrieved correctly
+            NotImplementedError: If backend does not
+                support batch updates.
+
+        """
+        raise NotImplementedError()
diff --git a/anitya/tests/lib/backends/test_folder.py b/anitya/tests/lib/backends/test_folder.py
@@ -40,7 +40,7 @@ class FolderBackendtests(DatabaseTestCase):
 
     def setUp(self):
         """Set up the environnment, ran before every tests."""
-        super(FolderBackendtests, self).setUp()
+        super().setUp()
 
         create_distro(self.session)