Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reorder y-axis order for kind of work demographics graph #9

Open
wants to merge 15 commits into
base: main
Choose a base branch
from

Conversation

kweav
Copy link
Contributor

@kweav kweav commented Aug 9, 2024

Reordered the y-axis kind of work response order such that the most responded description is on the top and the least responded description is on the bottom.

Should I add an asterisk to free-text responses (user-provided in the other/not originally displayed as an option?)

@kweav kweav requested a review from avahoffman August 9, 2024 16:02
Copy link
Contributor

github-actions bot commented Aug 9, 2024

No broken url errors! 🎉
Comment updated at 2024-09-20-20:46:59 with changes from d780752

Copy link
Contributor

github-actions bot commented Aug 9, 2024

No spelling errors! 🎉
Comment updated at 2024-09-20-20:46:59 with changes from d780752

@kweav
Copy link
Contributor Author

kweav commented Aug 9, 2024

@avahoffman I'm not familiar with the render preview error I'm getting on this PR.

Copy link
Contributor

github-actions bot commented Aug 9, 2024

👀 Quick preview of website here *
🔬 Comprehensive download of the website here

* note not all html features will be properly displayed in the "quick preview" but it will give you a rough idea.

Updated at 2024-09-20 with changes from the latest commit d780752

@avahoffman
Copy link
Contributor

avahoffman commented Aug 23, 2024

ggplot(experienceDf, aes(x=experienceLevel,y=n, fill=researchType)) +

^ I am not seeing where the object experienceDf is created.

EDIT: ah, I see extra depends on main.

@avahoffman
Copy link
Contributor

anvilPoll2024MainAnalysis.Rmd fails on:
PlotToolKnowledge_customization object

@kweav
Copy link
Contributor Author

kweav commented Aug 26, 2024

anvilPoll2024MainAnalysis.Rmd fails on: PlotToolKnowledge_customization object

@avahoffman Brought some changes from the rmdWork branch over here and the main Rmd knits for me locally now


# Provide a list of AnVIL only Tools
AnVIL_only <-
setdiff(toPlotToolKnowledgeSeparateBR[toPlotToolKnowledgeSeparateBR$UserType == "Current Users" &
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest formatting code on your chunks for readability
image

Copy link
Contributor

@avahoffman avahoffman Sep 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't this first plot (PlotToolKnowledge_customization(PlotToolKnowledge_potential_user_score)) in anvilPoll2024MainAnalysis?

PlotToolKnowledge_customization(PlotToolKnowledge_potential_user_score)
ggsave(here("plots/tooldataresourcecomfortscore_singlepanel_by_potential_users.png"), w = 2200, h = 1350, units = "px")

simplerPlot <- toPlotToolKnowledge %>%
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

simplerPlot can stay here


We're going to look at a comparison of the assigned ranks for these features, comparing between current users and potential users.

## Preferences: Feature Importance Ranking
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's make sure the order on the site, MainAnalysis, and ExtraAnalysis follow the same order.

  • Looks like site + MainAnalysis are pretty consistent, but ExtraAnalysis needs some work on the H2 headings.
  • Let's use the term "returning user" (instead of "current user") since that's what we used for the poll.

Site:
image

Main:
image

Extra:
image


### Awareness or Utilization Color rather than y-axis split

```{r}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add a theme(legend.title = element_blank()) + to these two.

Might be nice to place these two side by side (either facet or patchwork). Same with the "Awareness or Utilization Color rather than y-axis split" for AnVIL Demos.

@@ -11,7 +11,7 @@ library(here)
library(tidyverse)
library(magrittr)
library(grid) #for Grobs

library(scales)
Copy link
Contributor

@avahoffman avahoffman Sep 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any reason this is needed? You actually call tidyverse through scales in TidyData.Rmd so you don't need it here too

Comment on lines +226 to +232
## Experience: General interest in controlled access datasets

**Takeaway:** Over half of respondents report they are extremely interested in working with controlled access datasets.

## Experience: Controlled Access Datasets

**Takeaway:**
**Takeaway:** Of the survey provided choices, respondents have accessed or are particularly interested in accessing [All of Us](https://www.researchallofus.org/), [UK Biobank](https://www.ukbiobank.ac.uk/enable-your-research/about-our-data), and [GTEx](https://anvilproject.org/data/consortia/GTEx) (though All of Us and UK Biobank are not currently AnVIL hosted). 2 respondents (moderately or extremely experienced with genomic data) specifically wrote in ["TCGA"](https://www.cancer.gov/ccg/research/genome-sequencing/tcga). The trend of All of Us, UK Biobank, and GTEx being chosen the most is consistent across all 3 research categories (moderately or extremely experienced with clinical, human genomic, or non-human genomic data).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's condense these two H2s to Experience: Controlled Access Datasets.

It could look like:

## Experience: Controlled Access Datasets

**Takeaway:** Over half of respondents report they are extremely interested in working with controlled access datasets.

- Of the survey provided choices, respondents have accessed or are particularly interested in accessing [All of Us](https://www.researchallofus.org/), [UK Biobank](https://www.ukbiobank.ac.uk/enable-your-research/about-our-data), and [GTEx](https://anvilproject.org/data/consortia/GTEx) (though All of Us and UK Biobank are not currently AnVIL hosted). 
- 2 respondents (moderately or extremely experienced with genomic data) specifically wrote in ["TCGA"](https://www.cancer.gov/ccg/research/genome-sequencing/tcga). 
- The trend of All of Us, UK Biobank, and GTEx being chosen the most is consistent across all 3 research categories (moderately or extremely experienced with clinical, human genomic, or non-human genomic data).

stylize_bar(demoPlotRaw)
```

### Responses recoded to focus on awareness

```{r}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might want to set up default chunk options at the top to not show code, eg:

```{r, setup, include=FALSE}
knitr::opts_chunk$set(
  message = FALSE, echo = FALSE, warning = FALSE
)
```


```{r, message=FALSE, echo=FALSE}
forumdf <- resultsTidy %>%
mutate(AnVILSupportForum = str_replace(AnVILSupportForum, pattern = "No, ", replacement= "No ")) %>%
separate(AnVILSupportForum, c("forumInteractionA", "forumInteractionB", "forumInteractionC"),
mutate(AnVILSupportForum = str_replace(AnVILSupportForum,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again, would format code here using RStudio's built in feature

@@ -602,6 +657,17 @@ Finally, we'll reverse the x-axis so that most important is on the right and lea
</details>

```{r, message=FALSE, echo = FALSE}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can see you were playing around with the axes here, but we end up with the same (or very similar?) plot in the report. I'd just choose one so extra code isn't distracting.

geom_bar(stat="identity") +
ggtitle("How likely are you to recommend the AnVIL to a colleague?") +
coord_cartesian(clip = "off") +
theme(plot.margin = margin(1,1,1,1.1, "cm")) +
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

might need to make margins a little larger - x axis labels are cut off for me.

Copy link
Contributor

@avahoffman avahoffman Sep 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@@ -49,6 +49,26 @@ stylize_dumbbell <- function(gplot, xmax = NULL, importance = FALSE, preference
)
}

PlotToolKnowledge_customization <- function(gplot){
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Format

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants