-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
reorder y-axis order for kind of work demographics graph #9
base: main
Are you sure you want to change the base?
Conversation
No broken url errors! 🎉 |
No spelling errors! 🎉 |
@avahoffman I'm not familiar with the render preview error I'm getting on this PR. |
👀 Quick preview of website here * * note not all html features will be properly displayed in the "quick preview" but it will give you a rough idea. Updated at 2024-09-20 with changes from the latest commit d780752 |
^ I am not seeing where the object EDIT: ah, I see extra depends on main. |
anvilPoll2024MainAnalysis.Rmd fails on: |
@avahoffman Brought some changes from the |
|
||
# Provide a list of AnVIL only Tools | ||
AnVIL_only <- | ||
setdiff(toPlotToolKnowledgeSeparateBR[toPlotToolKnowledgeSeparateBR$UserType == "Current Users" & |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't this first plot (PlotToolKnowledge_customization(PlotToolKnowledge_potential_user_score)
) in anvilPoll2024MainAnalysis
?
PlotToolKnowledge_customization(PlotToolKnowledge_potential_user_score) | ||
ggsave(here("plots/tooldataresourcecomfortscore_singlepanel_by_potential_users.png"), w = 2200, h = 1350, units = "px") | ||
|
||
simplerPlot <- toPlotToolKnowledge %>% |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
simplerPlot
can stay here
anvilPoll2024ExtraAnalysis.Rmd
Outdated
|
||
We're going to look at a comparison of the assigned ranks for these features, comparing between current users and potential users. | ||
|
||
## Preferences: Feature Importance Ranking |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's make sure the order on the site, MainAnalysis, and ExtraAnalysis follow the same order.
- Looks like site + MainAnalysis are pretty consistent, but ExtraAnalysis needs some work on the H2 headings.
- Let's use the term "returning user" (instead of "current user") since that's what we used for the poll.
|
||
### Awareness or Utilization Color rather than y-axis split | ||
|
||
```{r} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's add a theme(legend.title = element_blank()) +
to these two.
Might be nice to place these two side by side (either facet or patchwork). Same with the "Awareness or Utilization Color rather than y-axis split" for AnVIL Demos.
@@ -11,7 +11,7 @@ library(here) | |||
library(tidyverse) | |||
library(magrittr) | |||
library(grid) #for Grobs | |||
|
|||
library(scales) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
any reason this is needed? You actually call tidyverse through scales in TidyData.Rmd so you don't need it here too
## Experience: General interest in controlled access datasets | ||
|
||
**Takeaway:** Over half of respondents report they are extremely interested in working with controlled access datasets. | ||
|
||
## Experience: Controlled Access Datasets | ||
|
||
**Takeaway:** | ||
**Takeaway:** Of the survey provided choices, respondents have accessed or are particularly interested in accessing [All of Us](https://www.researchallofus.org/), [UK Biobank](https://www.ukbiobank.ac.uk/enable-your-research/about-our-data), and [GTEx](https://anvilproject.org/data/consortia/GTEx) (though All of Us and UK Biobank are not currently AnVIL hosted). 2 respondents (moderately or extremely experienced with genomic data) specifically wrote in ["TCGA"](https://www.cancer.gov/ccg/research/genome-sequencing/tcga). The trend of All of Us, UK Biobank, and GTEx being chosen the most is consistent across all 3 research categories (moderately or extremely experienced with clinical, human genomic, or non-human genomic data). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's condense these two H2s to Experience: Controlled Access Datasets.
It could look like:
## Experience: Controlled Access Datasets
**Takeaway:** Over half of respondents report they are extremely interested in working with controlled access datasets.
- Of the survey provided choices, respondents have accessed or are particularly interested in accessing [All of Us](https://www.researchallofus.org/), [UK Biobank](https://www.ukbiobank.ac.uk/enable-your-research/about-our-data), and [GTEx](https://anvilproject.org/data/consortia/GTEx) (though All of Us and UK Biobank are not currently AnVIL hosted).
- 2 respondents (moderately or extremely experienced with genomic data) specifically wrote in ["TCGA"](https://www.cancer.gov/ccg/research/genome-sequencing/tcga).
- The trend of All of Us, UK Biobank, and GTEx being chosen the most is consistent across all 3 research categories (moderately or extremely experienced with clinical, human genomic, or non-human genomic data).
stylize_bar(demoPlotRaw) | ||
``` | ||
|
||
### Responses recoded to focus on awareness | ||
|
||
```{r} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might want to set up default chunk options at the top to not show code, eg:
```{r, setup, include=FALSE}
knitr::opts_chunk$set(
message = FALSE, echo = FALSE, warning = FALSE
)
```
|
||
```{r, message=FALSE, echo=FALSE} | ||
forumdf <- resultsTidy %>% | ||
mutate(AnVILSupportForum = str_replace(AnVILSupportForum, pattern = "No, ", replacement= "No ")) %>% | ||
separate(AnVILSupportForum, c("forumInteractionA", "forumInteractionB", "forumInteractionC"), | ||
mutate(AnVILSupportForum = str_replace(AnVILSupportForum, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Again, would format code here using RStudio's built in feature
@@ -602,6 +657,17 @@ Finally, we'll reverse the x-axis so that most important is on the right and lea | |||
</details> | |||
|
|||
```{r, message=FALSE, echo = FALSE} | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can see you were playing around with the axes here, but we end up with the same (or very similar?) plot in the report. I'd just choose one so extra code isn't distracting.
geom_bar(stat="identity") + | ||
ggtitle("How likely are you to recommend the AnVIL to a colleague?") + | ||
coord_cartesian(clip = "off") + | ||
theme(plot.margin = margin(1,1,1,1.1, "cm")) + |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
might need to make margins a little larger - x axis labels are cut off for me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -49,6 +49,26 @@ stylize_dumbbell <- function(gplot, xmax = NULL, importance = FALSE, preference | |||
) | |||
} | |||
|
|||
PlotToolKnowledge_customization <- function(gplot){ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Format
Co-authored-by: ava 🌱 <[email protected]>
Co-authored-by: ava 🌱 <[email protected]>
Co-authored-by: ava 🌱 <[email protected]>
Co-authored-by: ava 🌱 <[email protected]>
This is some of the rmd work that I'd been doing to clean it up, merging it so the branches are synced
Reordered the y-axis kind of work response order such that the most responded description is on the top and the least responded description is on the bottom.
Should I add an asterisk to free-text responses (user-provided in the other/not originally displayed as an option?)