Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: solves the duplicate variable name error in styles-to-variables plugin #150

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

JonatasT
Copy link

Hello! I believe the root cause of the issue #142 stems from having multiple styles associated with the same "token" name. To avoid a repeat of this incident, we can rectify the tokenData by appending a numerical suffix to the token style names. That being said, I have devised an alternate solution that may be of interest to you. Thank you for your time, and your attention.

Copy link
Collaborator

@akbarbmirza akbarbmirza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this change looks good to me but I would suggest adding some comments to explain this behavior and adding this limitation to a README for that sample so that people are explicitly aware that the sample is treating duplicate token names like this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants