Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: migrate variables sample to TS #158

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

MasaHirano
Copy link

Motivation

I am creating a plugin based on the variables-import-export sample. I found the code is relatively more complicated than other samples. Migrating it to TS as well as other samples will be beneficial from the perspective of readability and customizability.

{
"compilerOptions": {
"target": "ES6",
"lib": ["ES2017"],
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It requires ES2017 or newer unlike other samples using ES6. That's because in this code, functions like Object.entries are used

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant