Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add java gradle spring boot environment. #28

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Add java gradle spring boot environment. #28

wants to merge 5 commits into from

Conversation

tosone
Copy link
Contributor

@tosone tosone commented Jan 21, 2021

No description provided.

@tosone tosone mentioned this pull request Jan 21, 2021
Closed
@vishal-biyani
Copy link
Member

Hi @tosone

  • I see quite a few files with changes to path with comments "File renamed without changes." I think those are by mistake here
  • I don't see any difference in server.java or in the example hello world class - so technically would the same Spring environment which is available would work with Gradle built functions too?
  • There is a file java-maven-spring/examples/java/specs/README which seems misplaced
  • Also changes to file environments-ui/src/resources/environments.json needs fixing - there are many changes which are not needed.

vishal-biyani
vishal-biyani requested changes May 11, 2021
View reviewed changes
Copy link
Member

@vishal-biyani vishal-biyani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left comments in PR I think this needs some work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vishal-biyani vishal-biyani vishal-biyani requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tosone @vishal-biyani