Resolve "Divide by 0" error in stripe__line_item_enhanced
#89
+21
−7
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Overview
This PR will address the following Issue/Feature:
#86
This PR will result in the following new package version:
This specific change would be 0.14.1, but batched with the other existing Stripe PRs, the release will probably be a breaking change
Please provide the finalized CHANGELOG entry which details the relevant changes included in this PR:
Bug Fixes
Divide by 0
error in calculatingunit_amount
in thestripe__line_item_enhanced
model. Now, if the denominatorinvoice_line_item.quantity
is 0,unit_amount
will also be 0.PR Checklist
Basic Validation
Please acknowledge that you have successfully performed the following commands locally:
Before marking this PR as "ready for review" the following have been applied:
Detailed Validation
Please share any and all of your validation steps:
Adjusted
consistency_line_item_enhanced_count
test to also look at differences inunit_amount
(though this should be covered byconsistency_line_item_enhanced
as well) and all validation tests are passingIf you had to summarize this PR in an emoji, which would it be?
0️⃣