Limit simultaneous connections #316
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gasinvein
commented
Jul 19, 2022
Comment on lines
+79
to
+80
| conn_limit_per_host: int = 5 | ||
| conn_limit: int = 50 |
There was a problem hiding this comment.
@nanonyme IIRC you were the one who previously suggested to limit simultaneousl connections to prevent upstreams from throttling us. Does this seem like a reasonable default?
There was a problem hiding this comment.
@gasinvein in general you're better off having one connection per backend and using HTTP keepalive. TLS handshakes are slow.
There was a problem hiding this comment.
I'm afraid 1 connection per host will be way too slow: in many apps, there are several sources from GitHub.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should prevent some of the issue similar to #315.