Add option to show branch in PR title #332
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wjt
reviewed
Oct 13, 2022
| @@ -247,6 +248,11 @@ def open_pr( | |||
|
|
|||
| head = "{}:{}".format(repo.owner.login, change.branch) | |||
| pr_message = ((change.body or "") + "\n\n" + DISCLAIMER).strip() | |||
|
|
|||
| if branch_title: | |||
There was a problem hiding this comment.
or something like:
Suggested change
| if branch_title: | |
| if base not in ('master', 'beta'): |
There was a problem hiding this comment.
I personal prefer a argument, so the User can decide if he want it or not. There may be someone who uses f-e-d-c on the master and the beta branch and want to know, if a PR goes against the master or the beta branch.
|
I wonder if it could be more generic - instead of a boolean option determining whether or not to put branch name into PR title, use a string option with PR title template, with |
gasinvein
reviewed
Oct 13, 2022
| @@ -210,6 +210,7 @@ def open_pr( | |||
| change: CommittedChanges, | |||
| manifest_checker: manifest.ManifestChecker = None, | |||
| fork: t.Optional[bool] = None, | |||
| branch_title: t.Optional[bool] = None, | |||
There was a problem hiding this comment.
Suggested change
| branch_title: t.Optional[bool] = None, | |
| branch_title: bool = False, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
f-e-d-c is currently used by com.riverbankcomputing.PyQt.BaseApp on 3 different branches. Having the branch (e.g. 5.15-22.08 or 6.3) would make it possible to see which branch is targeted directly in the Notification or the PR list.
Note: This is currently not tested