test_checker: Don't try to fetch 10 random bytes as JSON #402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test was added in a5a8ee6 and keeps failing nondeterministically in CI: Traceback (most recent call last): File "/usr/lib/python3.11/unittest/async_case.py", line 90, in _callTestMethod if self._callMaybeAsync(method) is not None: ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/usr/lib/python3.11/unittest/async_case.py", line 112, in _callMaybeAsync return self._asyncioRunner.run( ^^^^^^^^^^^^^^^^^^^^^^^^ File "/usr/lib/python3.11/asyncio/runners.py", line 118, in run return self._loop.run_until_complete(task) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/usr/lib/python3.11/asyncio/base_events.py", line 653, in run_until_complete return future.result() ^^^^^^^^^^^^^^^ File "/home/runner/work/flatpak-external-data-checker/flatpak-external-data-checker/tests/test_checker.py", line 547, in test_get_json await checker._get_json("https://httpbingo.org/bytes/10") File "/home/runner/work/flatpak-external-data-checker/flatpak-external-data-checker/src/checkers/__init__.py", line 137, in _get_json return await response.json(content_type=None) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/usr/lib/python3/dist-packages/aiohttp/client_reqrep.py", line 1118, in json encoding = self.get_encoding() ^^^^^^^^^^^^^^^^^^^ File "/usr/lib/python3/dist-packages/aiohttp/client_reqrep.py", line 1072, in get_encoding encoding = chardet.detect(self._body)["encoding"] ^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/usr/lib/python3/dist-packages/charset_normalizer/legacy.py", line 26, in detect r = from_bytes(byte_str).best() ^^^^^^^^^^^^^^^^^^^^ File "/usr/lib/python3/dist-packages/charset_normalizer/api.py", line 212, in from_bytes is_multi_byte_decoder: bool = is_multi_byte_encoding(encoding_iana) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/usr/lib/python3/dist-packages/charset_normalizer/utils.py", line 256, in is_multi_byte_encoding importlib.import_module("encodings.{}".format(name)).IncrementalDecoder, ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/usr/lib/python3.11/importlib/__init__.py", line 126, in import_module return _bootstrap._gcd_import(name[level:], package, level) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "<frozen importlib._bootstrap>", line 1206, in _gcd_import File "<frozen importlib._bootstrap>", line 1175, in _find_and_load File "<frozen importlib._bootstrap>", line 171, in __enter__ File "<frozen importlib._bootstrap>", line 123, in acquire KeyError: 140113390399552 There is probably an actual bug here but, not today.
|
The error appears to be happening while guessing the charset. I suppose we can just disable charset detection in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test was added in a5a8ee6 and keeps failing nondeterministically in CI:
There is probably an actual bug here but, not today.