Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run flake8 on CI #415

Merged
merged 5 commits into from
Apr 30, 2024
Merged

Run flake8 on CI #415

merged 5 commits into from
Apr 30, 2024

Commits on Apr 25, 2024

  1. tests: Fix chromium checker test 

    It appears that all versions of chromium < 100 and LLVM < 14 have been
removed from the Google server. It would be better if the tests didn't
rely on real resources from the network, but that's a big can of worms
here. Update accordingly.
    @dbnicholson
    dbnicholson committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    f1f61d7 View commit details
    Browse the repository at this point in the history

  2. Fix black error 

    Apparently newer black prefers the ellipsis on the same line.
    @dbnicholson
    dbnicholson committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    b56cc35 View commit details
    Browse the repository at this point in the history

  3. Make flake8 config matching black 

    While flake8 thinks you shouldn't have a space before `:`, black thinks
you should. Silence flake8 since the code is expected to be formatted
with black.
    @dbnicholson
    dbnicholson committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    efa4818 View commit details
    Browse the repository at this point in the history

  4. Fix all the flake8 warnings and errors 

    There should be no functional changes here. Mostly there were line too
long warnings. After this both flake8 and black pass.
    @dbnicholson
    dbnicholson committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    dd676fc View commit details
    Browse the repository at this point in the history

  5. ci: Run flake8 in addition to black 

    black is a formatter while flake8 is a linter. Both are good to use.
    @dbnicholson
    dbnicholson committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    a9a32e1 View commit details
    Browse the repository at this point in the history