Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

manifest: Skip updating appdata if last source is not external #425

Merged
merged 1 commit into from
Jun 10, 2024
Merged

manifest: Skip updating appdata if last source is not external #425

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 13 additions & 4 deletions src/manifest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -486,10 +486,19 @@ def _update_appdata(self):
elif data.source_path == self._root_manifest_path:
selected_data = data
else:
# Guess that the last external source in the root manifest is the one
# corresponding to the main application bundle.
assert selected_data is not None
log.warning("Guessed upstream source: %s", selected_data)
if selected_data is not None:
# Guess that the last external source in the root manifest is the one
# corresponding to the main application bundle.
log.warning("Guessed last source as main source: %s", selected_data)
else:
log.error(
(
"No main source configured and no external source in "
"%s. Not updating appdata"
),
self._root_manifest_path,
)
return

last_update = selected_data.new_version

Expand Down
Loading