Update winston to 3.x #11
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@zoobot I cannot reproduce the issue anymore in this branch. Anyway I've added a test to prevent other warnings in the future. You can test the behavior with this script: var cliff = require('./lib/cliff.js');
process.on('warning', function() {
console.error("Oops, warning detected!");
});
var rows = [
['a', 'b'],
];
cliff.putRows('info', rows, ['red', 'blue']);When I run it on master branch: $ node --version
v15.12.0
$ node ./warning-test.js
info: a b
(node:39912) Warning: Accessing non-existent property 'padLevels' of module exports inside circular dependency
(Use `node --trace-warnings ...` to show where the warning was created)
Oops, warning detected!When I run it on this branch (be sure to delete $ node --version
v15.12.0
$ node ./warning-test.js
info: a bIf you're still having the issue, please provide an small example so I'm able to test it. |
meissnere
reviewed
Jun 22, 2021
meissnere
approved these changes
Jun 22, 2021
MatrixFrog
reviewed
Jan 28, 2022
lib/cliff.js
Outdated
| }); | ||
|
|
||
| // | ||
| // Set the default logger for cliff. | ||
| // | ||
| cliff.logger = new winston.Logger({ | ||
| transports: [new winston.transports.Console()] | ||
| cliff.logger = new winston.createLogger({ |
There was a problem hiding this comment.
Suggested change
| cliff.logger = new winston.createLogger({ | |
| cliff.logger = winston.createLogger({ |
There was a problem hiding this comment.
Oops you're right, I'll add it in a87d5da, thanks!
This warning came from winston 0.8.x:
Warning: Accessing non-existent property 'padLevels' of module
exports inside circular dependency
See foreversd/forever#1077
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is needed for foreversd/forever#1077.
Note that winston 3 requires Node.js >= 6.4.0 so this change breaks compatibility with older Node.js versions.