Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[camera] Example app: disposing focus mode row animation controller #7512

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

MrCsabaToth
Copy link
Contributor

Disposing the _focusModeControlRowAnimationController in the Example App's StatefulWidget's dispose method just like the other two row animation controllers.

Fixes flutter/flutter#154128

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group.

@@ -1,3 +1,7 @@
## 0.11.0+3

* Disposing Camera Example app's focus mode row animation controller.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should be able to remove this. This doesn't require a version bump since it is only changing the example app: https://github.com/flutter/flutter/blob/master/docs/ecosystem/contributing/README.md#version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[camera] Camera example app doesn't explicitly dispose focusModeControlRowAnimationController in dispose
2 participants