[camera] Making Camera Example app's setExposureOffset more robust #7514
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group. |
| try { | ||
| offset = await controller!.setExposureOffset(offset); | ||
| final appliedOffset = await controller!.setExposureOffset(offset); |
There was a problem hiding this comment.
This is missing a mounted check. Calling setState() after an await is potentially unsafe, as the widget might have unmounted.
There was a problem hiding this comment.
Usually local analysis points this out (async gap I think) and fails, not sure why not this time. I'll correct it!
| ## 0.11.0+3 | ||
|
|
||
| * Refactor Camera Example app's setExposureOffset to be possibly more robust. | ||
|
|
There was a problem hiding this comment.
Unpublished example app changes don't require a version change.
Refactor Camera Example app's
setExposureOffsetto be possibly more robust.Fixes flutter/flutter#154132
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style, or this PR is exempt from CHANGELOG changes.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.