[google_maps_flutter_android] Convert PlatformPolyline.pattern to Pigeon
#7631
+366
−160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reidbaker
reviewed
Sep 12, 2024
...ges/google_maps_flutter/google_maps_flutter_android/lib/src/google_maps_flutter_android.dart
Show resolved
Hide resolved
reidbaker
reviewed
Sep 12, 2024
packages/google_maps_flutter/google_maps_flutter_android/lib/src/messages.g.dart
Show resolved
Hide resolved
stuartmorgan
requested changes
Sep 12, 2024
...google_maps_flutter_android/android/src/main/java/io/flutter/plugins/googlemaps/Convert.java
Outdated
Show resolved
Hide resolved
...ges/google_maps_flutter/google_maps_flutter_android/lib/src/google_maps_flutter_android.dart
Show resolved
Hide resolved
11 tasks
stuartmorgan
approved these changes
Sep 14, 2024
|
|
||
| private static int toPixels(Object o, float density) { | ||
| return (int) toFractionalPixels(o, density); | ||
| } |
There was a problem hiding this comment.
Is this a bad merge? This is re-introducing unused, non-Pigeon conversion code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creates a structured
PlatformPatternItempigeon class to use inPlatformPolyline.flutter/flutter#154738
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style, or this PR is exempt from CHANGELOG changes.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.