[go_router] add current state getter #7651
Conversation
cedvdb
changed the title
cedvdb
changed the title
| @@ -167,6 +168,10 @@ class GoRouterDelegate extends RouterDelegate<RouteMatchList> | |||
| }()); | |||
| } | |||
|
|
|||
| /// The current [GoRouterState] | |||
| GoRouterState? get currentState => currentConfiguration.last | |||
| .buildState(_configuration, currentConfiguration); | |||
There was a problem hiding this comment.
Is there a way to access the last one without rebuilding the state here ?
There was a problem hiding this comment.
no unless you caches in the GoRouterStateRegistry, which is something i was planning to do at some point.
but I won't worry too much about this at the moment.
There was a problem hiding this comment.
also the document should mention what will be returned if you use GoRouter.push()
There was a problem hiding this comment.
This can also solve flutter/flutter#129833
Edit: nvm you already linked the issue
| @@ -167,6 +168,10 @@ class GoRouterDelegate extends RouterDelegate<RouteMatchList> | |||
| }()); | |||
| } | |||
|
|
|||
| /// The current [GoRouterState] | |||
| GoRouterState? get currentState => currentConfiguration.last | |||
| .buildState(_configuration, currentConfiguration); | |||
There was a problem hiding this comment.
no unless you caches in the GoRouterStateRegistry, which is something i was planning to do at some point.
but I won't worry too much about this at the moment.
| expect(state?.name, 'books'); | ||
| expect(state?.fullPath, '/books'); | ||
|
|
||
| router.go('/tulips'); |
There was a problem hiding this comment.
can you also do a push /tultips to make sure it can handle imperative shellroute push?
| @@ -167,6 +168,10 @@ class GoRouterDelegate extends RouterDelegate<RouteMatchList> | |||
| }()); | |||
| } | |||
|
|
|||
| /// The current [GoRouterState] | |||
| GoRouterState? get currentState => currentConfiguration.last | |||
| .buildState(_configuration, currentConfiguration); | |||
There was a problem hiding this comment.
also the document should mention what will be returned if you use GoRouter.push()
Adds a current state getter that returns
GoRouterState.I've no idea if this is correct but the added tests seem to be passing. Rebuilding the state may be expensive too ?
Fix: flutter/flutter#129833
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style, or this PR is exempt from CHANGELOG changes.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.