Update Wasm documentation #11131
Open
Update Wasm documentation #11131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Documentation was last updated for Flutter 3.22 and was outdated and misleading
JaffaKetchup
requested review from
sfshaza2,
parlough and
a team
as code owners
sfshaza2
reviewed
Sep 12, 2024
There was a problem hiding this comment.
Wow, this looks great to me! @johnpryan, @kevmoo, Can you weigh in?
|
/gcbrun |
|
Whoops, sorry, just fixed a small mistake ( |
|
Visit the preview URL for this PR (updated for commit 5480f94): |
|
/gcbrun |
kevmoo
reviewed
Sep 12, 2024
|
|
||
| If the application doesn't load: | ||
| ```dart |
There was a problem hiding this comment.
@yjbanov @eyebrowsoffire – thoughts here?
|
holy amazing @JaffaKetchup ! thank you! |
|
(No worries, I do enjoy a good bit of documentation improvements :D) |
|
@yjbanov, @eyebrowsoffire, can one of you weigh in on @kevmoo's question? |
|
Gentle ping, @yjbanov @eyebrowsoffire |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of what this PR is changing or adding, and why:
Documentation was last updated for Flutter 3.22 and was outdated and misleading. I've updated it to include that
flutter runis now supported, removed the experimental mentions (which conflict with the fact that it's now stable). I've also slightly reorganised some parts, as they are less necessary now thatflutter runworks, and added a way to actually verify whether Wasm is being used (two different methods, because one does not always seem 100% reliable)Presubmit checklist