Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

matomo_5: delete old unused files #1085

Merged
merged 2 commits into from
Sep 6, 2024
Merged

matomo_5: delete old unused files #1085

merged 2 commits into from
Sep 6, 2024

Conversation

laalsaas
Copy link
Collaborator

@laalsaas laalsaas commented Aug 20, 2024 •
edited by dpausp
Loading

PL-132236

@flyingcircusio/release-managers

Release process

Impact:

Changelog: (not yet ready to use, we are waiting for upstream commits to update the matomo package in our nixpkgs fork)

PR release workflow (internal)

  • PR has internal ticket
  • internal issue ID (PL-…) part of branch name
  • internal issue ID mentioned in PR description text
  • ticket is on Platform agile board
  • ticket state set to Pull request ready
  • if ticket is more urgent than within the next few days, directly contact a member of the Platform team

Design notes

  • Provide a feature toggle if the change might need to be adjusted/reverted quickly depending on context. Consider whether the default should be on or off. Example: rate limiting.
  • All customer-facing features and (NixOS) options need to be discoverable from documentation. Add or update relevant documentation such that hosted and guided customers can understand it as well.

Security implications

  • Security requirements defined? (WHERE)
    • pull in latest matomo version
  • Security requirements tested? (EVIDENCE)
    • tested upgrade from matomo 4 to matomo 5 on pntest00
    • tested setting up new matomo 5

@laalsaas laalsaas requested a review from dpausp August 20, 2024 14:18
@laalsaas laalsaas force-pushed the PL-132236-update-matomo-to-5-1-1 branch 11 times, most recently from 40c816b to 48f12d9 Compare August 23, 2024 20:54
@laalsaas laalsaas marked this pull request as draft August 23, 2024 21:06
@laalsaas laalsaas force-pushed the PL-132236-update-matomo-to-5-1-1 branch 3 times, most recently from 066e4f7 to 7472be0 Compare August 28, 2024 10:57
@laalsaas laalsaas force-pushed the PL-132236-update-matomo-to-5-1-1 branch from 7472be0 to b065b6d Compare September 4, 2024 15:58
@laalsaas laalsaas changed the title Update nixpkgs for matomo 5.1.1 Add migrationfor matomo 5.1.1 Sep 4, 2024
@laalsaas laalsaas marked this pull request as ready for review September 4, 2024 16:03
@dpausp dpausp changed the title Add migrationfor matomo 5.1.1 Add migration for matomo 5 Sep 4, 2024
dpausp
dpausp requested changes Sep 4, 2024
View reviewed changes
nixos/services/matomo.nix Outdated Show resolved Hide resolved
nixos/services/matomo.nix Outdated Show resolved Hide resolved
nixos/services/matomo.nix Outdated Show resolved Hide resolved
@laalsaas laalsaas changed the title Add migration for matomo 5 matomo_5: delete old unused files Sep 4, 2024
@laalsaas laalsaas force-pushed the PL-132236-update-matomo-to-5-1-1 branch 3 times, most recently from 03dd571 to bbb253a Compare September 6, 2024 13:32
@laalsaas laalsaas force-pushed the PL-132236-update-matomo-to-5-1-1 branch from bbb253a to d007dba Compare September 6, 2024 13:36
Philipp Neumann added 2 commits September 6, 2024 15:37
matomo5: fix upgrade issues
62ca1be
matomo: remove package from path of setup unit
e11fd65 
The only binary provided by the matomo package is matomo-console. This
will not work, our matomo directory is /var/lib/matomo, whereas the
matomo-console from the package will try to write in the nix store. We
have our own matomoConsole package, which provides a modified version of
matomoConsole that will use /var/lib/matomo.
@laalsaas laalsaas force-pushed the PL-132236-update-matomo-to-5-1-1 branch from d007dba to e11fd65 Compare September 6, 2024 13:38
@dpausp dpausp merged commit 4e0ed70 into fc-24.05-dev Sep 6, 2024
1 check passed
@dpausp dpausp deleted the PL-132236-update-matomo-to-5-1-1 branch September 6, 2024 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dpausp dpausp dpausp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@laalsaas @dpausp