Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[21.05] fix rabbitmq user updates for sensu #1091

Merged
merged 1 commit into from
Aug 29, 2024

Conversation

ctheune
Copy link
Contributor

@ctheune ctheune commented Aug 28, 2024

@flyingcircusio/release-managers

Release process

Impact:

n/a

Changelog:

  • Fix an inconsistency in our Sensu configuration management that caused machines to not properly get updated credentials.. (PL-132945)

PR release workflow (internal)

  • PR has internal ticket
  • internal issue ID (PL-…) part of branch name
  • internal issue ID mentioned in PR description text
  • ticket is on Platform agile board
  • ticket state set to Pull request ready
  • if ticket is more urgent than within the next few days, directly contact a member of the Platform team

Design notes

  • Provide a feature toggle if the change might need to be adjusted/reverted quickly depending on context. Consider whether the default should be on or off. Example: rate limiting.
  • All customer-facing features and (NixOS) options need to be discoverable from documentation. Add or update relevant documentation such that hosted and guided customers can understand it as well.

Security implications

Monitoring needs to work. This is also handling passwords and I've paid attention that we don't spill them in world readable files more than we already do (they're in the store, so ...).

  • Security requirements tested? (EVIDENCE)

manually verified in production due to critical need to see missing hosts

@ctheune ctheune changed the base branch from fc-24.05-dev to fc-21.05-dev August 28, 2024 14:15
Copy link
Member

@osnyx osnyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still waiting for the Hydra tests to pass, otherwise LGTM

@osnyx osnyx changed the title Pl 132945 fix rabbitmq user updates [21.05] fix rabbitmq user updates Aug 28, 2024
@osnyx osnyx changed the title [21.05] fix rabbitmq user updates [21.05] fix rabbitmq user updates for sensu Aug 28, 2024
@osnyx osnyx self-requested a review August 28, 2024 17:31
Copy link
Member

@osnyx osnyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sensu-server NixOS test currently fails.

Due to performance reasons we did not always change the passwords,
only for new users.

This caused inconsistencies more often than we can tolerate.

This now fixes it properly by parallelizing the updates, limiting to
CPU_COUNT-1 and also deleting superfluous users.

Fixes PL-132945
@ctheune ctheune force-pushed the PL-132945-fix-rabbitmq-user-updates branch from 3b4c4d7 to ac291d5 Compare August 29, 2024 06:25
@osnyx osnyx merged commit 2d4df6f into fc-21.05-dev Aug 29, 2024
2 checks passed
@osnyx osnyx deleted the PL-132945-fix-rabbitmq-user-updates branch August 29, 2024 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants