Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update channel to use downgraded kernel version. #1096

Merged

Conversation

sysvinit
Copy link
Member

@sysvinit sysvinit commented Sep 3, 2024

In the most recent nixpkgs update #1039 we released kernel version 5.15.165, however this has a bug in the virtio_net driver which causes network performance problems in VMs.

I've created a feature branch on our nixpkgs fork with the update commit reverted; this change switches our nixpkgs channel to use that feature branch, so we can continue to use 5.15.164, which does not have this regression.

PL-132971

@flyingcircusio/release-managers

Release process

Impact:

  • [NixOS 24.05] Machines will reboot to activate the downgraded kernel.

Changelog:

  • linux_5_15: 5.15.165 -> 5.15.164

PR release workflow (internal)

  • PR has internal ticket
  • internal issue ID (PL-…) part of branch name
  • internal issue ID mentioned in PR description text
  • ticket is on Platform agile board
  • ticket state set to Pull request ready
  • if ticket is more urgent than within the next few days, directly contact a member of the Platform team

Design notes

  • Provide a feature toggle if the change might need to be adjusted/reverted quickly depending on context. Consider whether the default should be on or off. Example: rate limiting.
  • All customer-facing features and (NixOS) options need to be discoverable from documentation. Add or update relevant documentation such that hosted and guided customers can understand it as well.

Security implications

  • Security requirements defined? (WHERE)
    • The most recently released new kernel version has a regression which may degrade service availability.
  • Security requirements tested? (EVIDENCE)
    • Checked on a DEV VM with the reproduction test against RadosGW.

Kernel 5.15.165 has a bug in the virto_net driver which causes network
performance issues, so switch to a feature branch which has been
downgraded to 5.15.164.

PL-132971
@ctheune ctheune merged commit a19f172 into fc-24.05-dev Sep 3, 2024
2 checks passed
@ctheune ctheune deleted the PL-132971-downgrade-kernel-network-regression branch September 3, 2024 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants