Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

webproxy/varnish: fix runtime/state dir issues and restart on unit changes #1104

Merged
merged 3 commits into from
Sep 19, 2024
Merged

webproxy/varnish: fix runtime/state dir issues and restart on unit changes #1104

merged 3 commits into from
Sep 19, 2024

Commits on Sep 18, 2024

  1. webproxy: explicitly set work dir for varnishncsa 

    Before, we relied on varnishncsa's behaviour, looking for the default
varnish work dir at /var/run/varnishd (where /var/run is linked to
/run). /run/varnishd is a symlink created by us, pointing to the real
location /var/spool/varnish/<hostname>.

Setting the work dir in the varnishncsa command line easier to
understand and less error-prone when the state dir changes.

PL-132901
    @dpausp @ctheune
    dpausp authored and ctheune committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    2a0117e View commit details
    Browse the repository at this point in the history

  2. webproxy: varnishncsa should have a runtime dir named after the service 

    Using /run/varnish for the varnishncsa was quite confusing and can lead
to weird errors when varnish uses the same run time dir and restarting
one of the services clears the runtime directory for both. We don't do
that at the moment, but the varnish work dir can be changed.

PL-132901
    @dpausp @ctheune
    dpausp authored and ctheune committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    26f41c5 View commit details
    Browse the repository at this point in the history

  3. webproxy/varnish: final version of the fix to manage the varnish stat… 

    …e dir properly

a) use the real varnish upstream state directory
b) only reload if it's a pure VCL change, restart otherwise

For channel upgrades (e.g. when this statedir change is rolled out) this
happens in maintenance anyway. We'll provide better public docs about
the restart conditions in the near future.

PL-132901
    @ctheune
    ctheune committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    503e925 View commit details
    Browse the repository at this point in the history