Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rclone: add as default platform package #1109

Merged
merged 1 commit into from
Sep 18, 2024

Conversation

osnyx
Copy link
Member

@osnyx osnyx commented Sep 18, 2024

rclone is a useful tool that is part of many of our workflows nowadays. Add it to the platform default packages.
also added to important-packages to keep track of version changes

@flyingcircusio/release-managers

Release process

Impact:

Changelog:

  • rclone: add as default platform package

PR release workflow (internal)

  • PR has internal ticket
  • internal issue ID (PL-…) part of branch name
  • internal issue ID mentioned in PR description text
  • ticket is on Platform agile board
  • ticket state set to Pull request ready
  • if ticket is more urgent than within the next few days, directly contact a member of the Platform team

Design notes

  • Provide a feature toggle if the change might need to be adjusted/reverted quickly depending on context. Consider whether the default should be on or off. Example: rate limiting.
  • All customer-facing features and (NixOS) options need to be discoverable from documentation. Add or update relevant documentation such that hosted and guided customers can understand it as well.

Security implications

  • Security requirements defined? (WHERE)
    • none, just another default package that does not expose s running service nor is setuid
  • Security requirements tested? (EVIDENCE)
    • automated tests still need to pass though

also added to important-packages to keep track of version changes
@osnyx osnyx requested a review from ctheune September 18, 2024 14:31
@ctheune ctheune merged commit 6185312 into fc-24.05-dev Sep 18, 2024
2 checks passed
@ctheune ctheune deleted the os-rclone-platform-24.05 branch September 18, 2024 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants