Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[24.11] security.acme.defaults.server: customise only for stateVersion <= 24.05 #1112

Merged
merged 2 commits into from
Sep 23, 2024
Merged

[24.11] security.acme.defaults.server: customise only for stateVersion <= 24.05 #1112

merged 2 commits into from
Sep 23, 2024
+10 −6

Commits on Sep 23, 2024

  1. security.acme.defaults.server: customise only for stateVersion <= 24.05 

    In PL-132659, we've decided to override security.acme.defaults.server from the upstream value to avoid triggering mass letsencrypt account re-registrations.

**Re-**registrations are only an issue for existing machines. Freshly bootstrapped systems won't cause any problems. As we cannot be certain that our workaround is going to work for all future NixOS releases, I propose to make this conditional on the VM state version <= 24.05. If ever necessary, this reduces the number of VMs in need of a state migration for the account in the future.

PL-133038
    @osnyx
    osnyx committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    e31b7bb View commit details
    Browse the repository at this point in the history

  2. pre-commit fixes

    @osnyx
    osnyx committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    0d44434 View commit details
    Browse the repository at this point in the history