-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add base router for webapp #233
Conversation
Reviewer's Guide by SourceryThis pull request implements a base router for the webapp, allowing configuration of a subpath for the video application. The changes involve updating the base path for the webapp component using a basePath from the config file. This affects routing, CORS settings, and domain validation. File-Level Changes
Tips
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @lcduong - I've reviewed your changes - here's some feedback:
Overall Comments:
- The CORS origin whitelist has been simplified. Could you clarify if the removal of specific subdomains (like video-dev.eventyay.com) is intentional and won't cause issues for existing users?
- The domain validation regex has been updated to allow subpaths. While this aligns with the PR's goal, please review to ensure it's not overly permissive and doesn't introduce security risks.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
In order to config subpath for video application, I update base path for webapp component, using basePath from config file
Summary by Sourcery
Add a base path configuration for the web application router to support subpath routing, update domain validation to allow subpaths, and adjust development server settings to accommodate new subdomains.
New Features:
Enhancements:
Build:
Chores: