Fixed block explorer links #2466
Open
+319
−47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
integraledelebesgue
requested review from
ksew1,
cptartur and
ddoktorski
as code owners
ddoktorski
reviewed
Sep 13, 2024
|
Please also link issue #2425 to this PR |
5 tasks
cptartur
approved these changes
Sep 20, 2024
Comment on lines
+179
to
+192
| async fn assert_valid_links(input: &str) { | ||
| let pattern = Regex::new(r"transaction: |contract: |class: ").unwrap(); | ||
| let links = pattern.replace_all(input, ""); | ||
| let mut links = links.split('\n'); | ||
|
|
||
| let contract = links.next().unwrap(); | ||
| let transaction = links.next().unwrap(); | ||
|
|
||
| let (contract_response, transaction_response) = | ||
| tokio::join!(reqwest::get(contract), reqwest::get(transaction)); | ||
|
|
||
| assert!(contract_response.is_ok()); | ||
| assert!(transaction_response.is_ok()); | ||
| } |
There was a problem hiding this comment.
Not 100% like this being reliant on the order of links and a regex. But I see that rust doesn't really support lookbehind/lookahead in regex.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2425
Closes #2429
Introduced changes
Checklist
CHANGELOG.md