Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove default from Employee Leave Balance report (backport #2172) #2191

Merged

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Sep 16, 2024

Version 15 and 14

  • There's no need to define the default value because it won’t work that way. Remove it, and if a leave period is created, it will be set in the onload event, which is already defined. So, remove the line below:
default: frappe.defaults.get_default("year_start_date"),
```<hr>This is an automatic backport of pull request #2172 done by [Mergify](https://mergify.com).

* fix: from/to date in Employee Leave Balance report

* fix: remove default from Employee Leave Balance report

* fix: remove default from Employee Leave Balance report

(cherry picked from commit 89ac696)
@ruchamahabal ruchamahabal merged commit 028b1e1 into version-15-hotfix Sep 16, 2024
5 checks passed
@mergify mergify bot deleted the mergify/bp/version-15-hotfix/pr-2172 branch September 16, 2024 07:08
frappe-pr-bot pushed a commit that referenced this pull request Sep 18, 2024
# [15.29.0](v15.28.3...v15.29.0) (2024-09-18)

### Bug Fixes

* expire_allocation api endpoint by fetching allocation object (backport [#1576](#1576)) ([#2195](#2195)) ([a0e8ddf](a0e8ddf))
* **Income Tax Computation:** consideration of new employees without prexisting salary slips ([a2033c1](a2033c1))
* mark translatable strings in setup fixtures (backport [#2129](#2129)) ([#2196](#2196)) ([a61d8cf](a61d8cf))
* **Monthly Attendance Sheet:** consideration of None values while grouping ([00e57e1](00e57e1))
* remove default from Employee Leave Balance report (backport [#2172](#2172)) ([#2191](#2191)) ([028b1e1](028b1e1))
* show shift for month full of leaves ([11223ca](11223ca))
* year_start_date in Employee Advance Summary (backport [#2165](#2165)) ([#2193](#2193)) ([94ca0c5](94ca0c5))

### Features

* **Monthly Attendance Sheet:** add Include Company Descendants filter ([93a0431](93a0431))
@frappe-pr-bot
Copy link
Collaborator

🎉 This PR is included in version 15.29.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants