Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test Profile edit #1677

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from
Open

Test Profile edit #1677

wants to merge 3 commits into from

Conversation

hilalnigarbasan
Copy link
Contributor

No description provided.

Copy link

vercel bot commented Sep 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 15, 2024 9:54pm
foundation ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 15, 2024 9:54pm
kunsthalte ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 15, 2024 9:54pm
trend-rights ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 15, 2024 9:54pm
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
lotus ⬜️ Ignored (Inspect) Visit Preview Sep 15, 2024 9:54pm
wsvvui ⬜️ Ignored (Inspect) Visit Preview Sep 15, 2024 9:54pm

Copy link

alwaysmeticulous bot commented Sep 15, 2024

✅ Meticulous spotted zero visual differences across 161 screens tested: view results.

Expected differences? Click here. Last updated for commit f1fec13. This comment will update as new commits are pushed.

@7alip 7alip changed the base branch from main to dev September 15, 2024 21:18
@7alip 7alip self-requested a review September 15, 2024 21:18
Copy link
Sponsor Contributor

@7alip 7alip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Description

I updated your branch with the latest dev. Please run git pull first.

I added new error and success (toast) message locators for update username/email/password.


Todo

Could you add your assertion here:

// TODO: Add assertion for success toast


Extra

New locators are:

      usernameSuccess: page.locator('#toast-success-update-username'),
      usernameError: page.locator('#toast-error-update-username'),
      emailSuccess: page.locator('#toast-success-update-email'),
      emailError: page.locator('#toast-error-update-email'),
      passwordSuccess: page.locator('#toast-success-update-password'),
      passwordError: page.locator('#toast-error-update-password'),

You will be checking if profilePage.toasts.passwordSuccess is visible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants