Fix diagnostic output #9
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If an unknown command line argument is given, at least show which index is affected. Signed-off-by: Tobias Stoeckmann <[email protected]>
The maximum spare leases are 255, not 256. This limit is due to the underlying type used. Signed-off-by: Tobias Stoeckmann <[email protected]>
neocturne
reviewed
May 29, 2023
| @@ -382,7 +382,7 @@ int main(int argc, char** argv) { | |||
| break; | |||
|
|
|||
| default: | |||
| printf("ARGC: %i\n", argc); | |||
| printf("Unknown argument at index %i\n", optind); | |||
There was a problem hiding this comment.
Can we print the unrecognized argument string instead?
There was a problem hiding this comment.
We had a quick discussion about this in our review and without further investigation into the workings of getopt here, this was the least intrusive patch we could find. We can take another look at this to see if the needed string is readily available.
There was a problem hiding this comment.
We were unsure re this, because of folding of short options.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also give more information in case of invalid command line arguments.
Fix help message.