Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gluon-authorized-keys: add unauthorized_keys to remove access #2782

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

mkg20001
Copy link
Member

@mkg20001 mkg20001 commented Feb 5, 2023

No description provided.

@github-actions github-actions bot added 3. topic: docs Topic: Documentation 3. topic: package Topic: Gluon Packages labels Feb 5, 2023
@mkg20001 mkg20001 marked this pull request as draft February 17, 2023 23:44
@mkg20001
Copy link
Member Author

revoew discussion summarized:

  • the unauthorized_keys feature in it's current state is not wanted
  • the goal of authorized_keys was never meant to be a mechanism for rolling out keys

the reworked version:

  • groups instead of main authorized keys, which are disabled by default (similar to ffda-ssh-manager)
  • /etc/dropbear/authorized_keys -> /var/authorized_keys symlink, generate from /etc/config/authorized_keys? (persistent keys) and the enabled groups
  • migration that moves /etc/dropbear/authorized_keys to persistent location and replaces it with symlink to generated version. generated version will also have read-only flag set.
  • persistent additions to the persistent (!) authorized_keys file should still be possible via site.conf
  • there should be a webui for the groups

@AiyionPrime AiyionPrime added the 2. status: waiting-on-author Waiting on some action from the author label Mar 22, 2023
@blocktrron
Copy link
Member

I think this is a compromise in every aspect.

Over at freifunk-gluon/community-packages#24 we have a IMHO better solution to manage site-keys. This allows also to differentiate between site-originated keys as well as user-added SSH keys.

In my opinion, we can merge this and work towards integrating the community package into core-gluon, deprecating the current way of adding SSH keys using site-information.

@@ -13,3 +13,13 @@ If you select this package, add a list of authorized keys to ``site.conf`` like
...

Existing keys in ``/etc/dropbear/authorized_keys`` will be preserved.

If you want to remove specific keys in the future, specify them like this:::
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Take note here that this will also remove SSH key which are originally added by the user.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2. status: waiting-on-author Waiting on some action from the author 3. topic: docs Topic: Documentation 3. topic: package Topic: Gluon Packages needs work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants