Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add abbility to create custom VLANs to network settings #2907

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

mkg20001
Copy link
Member

@mkg20001 mkg20001 commented May 21, 2023

This is originally from @lemoer's PR

The patch works as-is but the UI is a bit wonky

DSA is a hard requirement for all switches,
so the existence of swconfig should disable this feature (if there are any non-DSA devices left after 23)

Bugs:

  • Creating/deleting a VLAN interface shows change only after reload/save => generate after applying changes
  • Interfaces that should not be used can be used (for example eth0 on hap ac2 should be left alone) => disabled on swconfig devices as it's unusuable there

image

@mkg20001
Copy link
Member Author

mkg20001 commented Jun 10, 2023

swconfig devices display a warning instead of ui being shown

The current method of only displaying after write is buggy, perhaps there could be a better way to hook that

image

@github-actions github-actions bot added the 3. topic: hardware Topic: Hardware Support label Jun 10, 2023
@mkg20001
Copy link
Member Author

the reload fix causes the settings of individual interfaces to not be saved, as they are created too late

This is originally from @lemoer's PR

The patch works as-is but the UI is a bit wonky

DSA is a hard requirement for all switches,
so the existence of swconfig should disable this feature
(if there are any non-DSA devices left after 23)
@maurerle
Copy link
Member

Are there still bugs with this PR?
What is the current state of it?

@mkg20001
Copy link
Member Author

Sortof. So the issue is that interfaces don't show up / don't vanish correctly aswell as remove not working which is a circular dependency we can't resolve in the old ui system.

There isn't a good solution other than the planned rewrite of the webinterface, which will take a bit longer.

If the patchset works for you despite those bugs you can also unoffically use it until then, but since it's not really working how it's supposed to we won't move forward until I get time to get the new frontend part done.

@Djfe
Copy link
Contributor

Djfe commented Aug 29, 2023

so if we want to remove an interface we created, we might need to do "firstboot" since it currently doesn't work at all (without the interface rewrite)?

@mkg20001
Copy link
Member Author

mkg20001 commented Aug 29, 2023

just removing it from /etc/config/gluon should be enough.

btw, it's just the ui. you can copy-paste those vlans on any device with dsa and they will just work. (after reconfigure and without this VLAN ui patch)

config interface 'iface_eth0_vlan255'
	option name 'eth0.255'
	list role 'mesh'

@Djfe
Copy link
Contributor

Djfe commented Aug 29, 2023

should or I run gluon-reconfigure afterwards?

@mkg20001
Copy link
Member Author

yes and then gluon-reload (or better reboot)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. topic: config-mode This is about the configuration mode 3. topic: package Topic: Gluon Packages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants