gluon-status-page: migrate JS to es2015-standard
#2959
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
3. topic: package
neocturne
reviewed
Sep 7, 2023
Fix warning by Chrome: Canvas2D: Multiple readback operations using getImageData are faster with the willReadFrequently attribute set to true. See: https://html.spec.whatwg.org/multipage/canvas.html#concept-canvas-will-read-frequently
Rotzbua
force-pushed
the
gluon-status-page_js
branch
from
dcbf9b1
to
6d7d6b1
Compare
neocturne
requested changes
Oct 13, 2023
| try { | ||
| location = JSON.parse(document.body.getAttribute('data-node-location')); | ||
| } catch (e) { | ||
| console.error(e); |
There was a problem hiding this comment.
There is nothing wrong with a node not providing a location, this should not be logged.
We are slightly abusing the try/catch here though, something like the following would be nicer (untested):
const location_attr = document.body.getAttribute('data-node-location');
let location;
if (location_attr)
location = JSON.parse(location_attr);| try { | ||
| lastImage = ctx.getImageData(0, 0, w, h); | ||
| } catch (e) {} | ||
| } catch (e) { | ||
| console.error(e); |
There was a problem hiding this comment.
I'm not sure whether this should be logged. Unfortunately, I don't remember why I added the try/catch here...
MDN describes two possible exceptions: https://developer.mozilla.org/en-US/docs/Web/API/CanvasRenderingContext2D/getImageData#exceptions
I don't think we can hit the SecurityError, so maybe this was just an ugly way to catch w or h being zero?
|
@Rotzbua Do you still have plans for addressing the suggestions? |
|
closing due to lack of reaction |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change
es2015-standardCanvas2D: Multiple readback operations using getImageData are faster with the willReadFrequently attribute set to true. See: https://html.spec.whatwg.org/multipage/canvas.html#concept-canvas-will-read-frequentlyReference
Mentioned in #2953