wgpeerselector: expect actual traffic flow #253
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Situations may happen in which handshakes are being received, but no actual traffic flows. This commit adds checks on whether the tx/rx byte values have changed. If not the connection is handled as being broken.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: We are still examining the situation. Please don't merge! This PR is only meant for discussion purposes atm.
Situations may happen in which handshakes are being received, but no actual traffic flows.
This commit adds checks on whether the tx/rx byte values have changed.
If not the connection is handled as being broken.
Another issue is that it takes up to 150 seconds for a node to recognize a broken connection as WireGuard only sends handshakes every two minutes. This can only be mitigated by checking if the received bytes value changed.