Remove Gen.eval and refactor Gen.sample #383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kurtschelfthout
changed the title
kurtschelfthout
changed the title
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #268 and fixes #236.
I actually agree that
evalis confusing so I've removed it.I added extra functions in F# and overloads in C# of sample instead:
sampletakes a desired number of valuessampleWithSizetakes size in additionsampleWithSeedtakes seed in addition to make it deterministicIn C# the API is much nicer, there is just one
Sampleextension method onGenwith optional seed and size arguments.