Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace geometries module/functions with features module/functions #1011

Merged
merged 11 commits into from
Jun 27, 2023

Conversation

gboeing
Copy link
Owner

@gboeing gboeing commented Jun 24, 2023

resolves #1008

@codecov
Copy link

codecov bot commented Jun 24, 2023

Codecov Report

Attention: Patch coverage is 97.47292% with 7 lines in your changes missing coverage. Please review.

Project coverage is 98.06%. Comparing base (8f789a9) to head (50bc9ca).
Report is 979 commits behind head on main.

Files with missing lines Patch % Lines
osmnx/features.py 97.23% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1011      +/-   ##
==========================================
+ Coverage   98.04%   98.06%   +0.02%     
==========================================
  Files          23       24       +1     
  Lines        2407     2433      +26     
==========================================
+ Hits         2360     2386      +26     
  Misses         47       47              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gboeing gboeing changed the base branch from main to ci June 26, 2023 23:45
@gboeing gboeing changed the base branch from ci to main June 26, 2023 23:45
@gboeing gboeing merged commit 7f8154d into main Jun 27, 2023
5 of 6 checks passed
@gboeing gboeing deleted the features branch June 27, 2023 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Should the geometries module be renamed features?
1 participant