better handling of null geometry column #1012
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1012 +/- ##
==========================================
- Coverage 98.04% 98.04% -0.01%
==========================================
Files 23 23
Lines 2409 2407 -2
==========================================
- Hits 2362 2360 -2
Misses 47 47 ☔ View full report in Codecov by Sentry. |
gboeing
requested changes
Jun 27, 2023
There was a problem hiding this comment.
Thanks @martinfleis I appreciate you taking a look. Tests failed silently (due to a bug fixed by #1014). I made a change to fix the linter and proposed a change to fix the tests. Let me know what you think.
gboeing
approved these changes
Jun 27, 2023
gboeing
added a commit
that referenced
this pull request
Jun 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1006
This should result in the same GeoDataFrame without intermediate steps which behaviour will change in future.