Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add kwargs to _getaddrinfo #1039

Merged
merged 2 commits into from
Jul 21, 2023
Merged

Add kwargs to _getaddrinfo #1039

merged 2 commits into from
Jul 21, 2023

Conversation

phofl
Copy link
Contributor

@phofl phofl commented Jul 21, 2023

Read these instructions carefully

Before you proceed, review the contributing guidelines in the CONTRIBUTING.md file, especially the sections on project coding standards and tests.

In this pull request, please include:

  • a reference to related issue(s)
  • a description of the changes proposed in the pull request
  • an example code snippet illustrating usage of the new functionality

We defined some keyword only arguments in dask/distributed. This will raise exceptions if you download data before triggering a Dask computation on a cluster. A related post is here: https://stackoverflow.com/questions/75763037/dask-throws-dns-typeerror-if-osmnx-download-data-beforehand

Adding kwargs should be neutral for osmnx but would make this work together with a dask cluster.

@codecov
Copy link

codecov bot commented Jul 21, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.59%. Comparing base (ace277a) to head (9e0b9d1).
Report is 846 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1039   +/-   ##
=======================================
  Coverage   97.59%   97.59%           
=======================================
  Files          24       24           
  Lines        2454     2454           
=======================================
  Hits         2395     2395           
  Misses         59       59           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gboeing gboeing merged commit 42402cd into gboeing:main Jul 21, 2023
4 checks passed
@phofl phofl deleted the kwargs branch July 21, 2023 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants