feat!: use zero questions mode by default. #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
KuznetsovRoman
commented
Apr 22, 2024
KuznetsovRoman
commented
- use zero questions mode by default.
- "-y" argv replaced with "-v" with opposite meaning
- "noQuestions" replaced with "extraQuestions" with opposite meaning
KuznetsovRoman
force-pushed
the
HERMIONE-1522.no_questions_testplane
branch
2 times, most recently
from
b7e6393
to
93fb3c0
Compare
sipayRT
reviewed
Apr 22, 2024
|
|
||
| You can add `-y` or `--yes` argument to launch a tool in *no-questions* mode: | ||
| By default, project will be created with zero questions. |
There was a problem hiding this comment.
almost zero questions - there may be a question about downloading the npm-package :)
docs/en/create-testplane.md
Outdated
| ``` | ||
|
|
||
| In this mode you won't be asked questions about desired plugins and packet manager. | ||
|
|
||
| Default packet manager, used with `--yes` argument: `npm` | ||
| Default packet manager, used without `--verbose` argument: `npm` | ||
|
|
||
| Default plugins, installed with `--yes` argument: |
There was a problem hiding this comment.
here we can remove part installed with --yes argument
There was a problem hiding this comment.
I will replace it with "without --verbose argument"
| @@ -17,11 +17,11 @@ const argv = yargs(hideBin(process.argv)) | |||
| description: "Language, which will be used to write Testplane tests", | |||
| choices: ["ts", "js"], | |||
| }) | |||
| .option("yes", { | |||
There was a problem hiding this comment.
instead of removing this option we can set default value as true (we have many examples with -y option)
There was a problem hiding this comment.
How would we turn it off then?
You still can use -y option (as well as -f, -o, -o, -b, -a, -r), it just does nothing
sipayRT
approved these changes
Apr 22, 2024
feat!: "-y" argv replaced with "-v" with opposite meaning feat!: "noQuestions" replaced with "extraQuestions" with opposite meaning BREAKING CHANGE: use zero questions mode by default. BREAKING CHANGE: "-y" argv replaced with "-v" with opposite meaning. BREAKING CHANGE: "noQuestions" replaced with "extraQuestions" with opposite meaning.
KuznetsovRoman
force-pushed
the
HERMIONE-1522.no_questions_testplane
branch
from
93fb3c0
to
537617b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.