unpack: Don't display "Unpacking ..." for skipped files, match file extensions case-sensitively #1379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please, if possible, include the PR description within the commit message(s) where appropriate, so that the relevant info is encoded just in the git repo. |
mgorny
reviewed
Sep 9, 2024
PMS says that "Any unrecognised file format shall be skipped silently." This wording was added with the draft of what later became EAPI 4: https://gitweb.gentoo.org/proj/pms.git/commit/?id=634c32f231e1bc94d64588e2b2edf0ad1ca60f1f The commit message doesn't give any rationale for "silently". It may well be that the wording is a remnant of the rejected "unpack --if-compressed" item. See the discussion in the 2009-04-23 council meeting: https://projects.gentoo.org/council/meeting-logs/20090423.txt (starting at 21:35). Signed-off-by: Ulrich Müller <[email protected]>
This fixes PMS compliance and at the same time simplifies the code. Signed-off-by: Ulrich Müller <[email protected]>
Signed-off-by: Ulrich Müller <[email protected]>
Signed-off-by: Ulrich Müller <[email protected]>
floppym
approved these changes
Sep 9, 2024
thesamesam
approved these changes
Sep 9, 2024
|
Merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in
#gentoo-pms.PMS currently says that "Any unrecognised file format shall be skipped silently." This wording was added with the draft of what later became EAPI 4: https://gitweb.gentoo.org/proj/pms.git/commit/?id=634c32f231e1bc94d64588e2b2edf0ad1ca60f1f
The commit message doesn't give any rationale for "silently". It may well be that the wording is a remnant of the rejected
unpack --if-compresseditem. See the discussion in the 2009-04-23 council meeting (starting at 21:35).Patch for PMS (presumably, replacing "silently" with "without raising an error") will follow.