Skip to content

Commit

Permalink
update to latest rust, drop msrv since older versions fail to build s…
Browse files Browse the repository at this point in the history
…pade

  cargo check --all-targets --no-default-features

Build error is:

https://github.com/georust/geo/actions/runs/10101238242/job/27934367105?pr=1197

error[E0446]: crate-private type `PointWithIndex<V>` in public interface
   --> /usr/local/cargo/registry/src/index.crates.io-6f17d22bba15001f/spade-2.10.0/src/delaunay_core/bulk_load.rs:357:1
    |
342 |   pub(crate) struct PointWithIndex<V> {
    |   ----------------------------------- `PointWithIndex<V>` declared as crate-private
...
357 | / pub fn bulk_load_stable<V, T, T2, Constructor>(
358 | |     constructor: Constructor,
359 | |     elements: Vec<V>,
360 | | ) -> Result<T, InsertionError>
...   |
370 | |     >,
371 | |     Constructor: FnOnce(Vec<PointWithIndex<V>>) -> Result<T2, InsertionError>,
    | |______________________________________________________________________________^ can't leak crate-private type
  • Loading branch information
michaelkirk committed Jul 25, 2024
1 parent 162a091 commit 223bb13
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/imagebuild.yml
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ jobs:

strategy:
matrix:
rust_version: ["1.70", 1.76, 1.77]
rust_version: ["1.74", 1.79, 1.80]

steps:
- name: Check out repository
Expand Down Expand Up @@ -81,7 +81,7 @@ jobs:
{image: proj-ci, testcmd: "git clone https://github.com/georust/proj && cd proj && cargo test --no-default-features && cargo test --features bundled_proj && cargo test --features network && cd proj-sys && _PROJ_SYS_TEST_EXPECT_BUILD_FROM_SRC=0 cargo test && _PROJ_SYS_TEST_EXPECT_BUILD_FROM_SRC=1 cargo test --features bundled_proj"},
{image: proj-ci-without-system-proj, testcmd: "git clone https://github.com/georust/proj && cd proj && cargo test --features bundled_proj && cd proj-sys && _PROJ_SYS_TEST_EXPECT_BUILD_FROM_SRC=1 cargo test"}
]
rust_version: ["1.70", 1.76, 1.77]
rust_version: ["1.74", 1.79, 1.80]

steps:
- name: Check out repository
Expand Down

0 comments on commit 223bb13

Please sign in to comment.