[i18n_subsites]: Fix broken feed links #1299
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avaris
reviewed
Sep 17, 2020
i18n_subsites/i18n_subsites.py
Outdated
Comment on lines
107
to
108
| if 'FEED_DOMAIN' not in overrides: | ||
| overrides['FEED_DOMAIN'] = posixpath.join(main_siteurl, lang) |
There was a problem hiding this comment.
This should probably use settings['FEED_DOMAIN'] instead of main_siteurl
There was a problem hiding this comment.
I changed what you said @avaris, but I think it's not the best idea. If you have FEED_DOMAIN set to SITEURL + '/feeds', for example, the link to the feeds for Czech will be like http://example.com/test/feeds/cz/all.atom.xml, and this plugin doesn't organize the output that way, so the links are broken.
In this case, when FEED_DOMAIN is None, it works just fine, but if it's provided it makes things more difficult and unexpected with that change.
rschiang
added a commit
to rschiang/pelican-plugins
that referenced
this pull request
Aug 9, 2022
[i18n_subsites]: Fix broken feed links
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think it fixes #1033