Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sorted subsections #2372

Open
wants to merge 4 commits into
base: next
Choose a base branch
from
Open

Sorted subsections #2372

wants to merge 4 commits into from

Conversation

bemyak
Copy link
Contributor

@bemyak bemyak commented Dec 13, 2023

This PR adds subsection sorting and introduces lower and higher fields to make sections more consistent with pages. As pointed here, these fields are supposed to be there.

An open question remains: how should we treat subsections of a transparent section? I raised this question here, but so far there is no definite conclusion, so I'm leaving it out of the scope of this PR.


Sanity check:

  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Code changes

  • Are you doing the PR on the next branch?
  • Have you created/updated the relevant documentation page(s)?

As per Vincent's comment, the subsections should have the same lower/higher properties as pages.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants