Allow treating a missing highlight language as error #2642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Keats
reviewed
Sep 19, 2024
| @@ -27,6 +41,8 @@ pub struct ThemeCss { | |||
| pub struct Markdown { | |||
| /// Whether to highlight all code blocks found in markdown files. Defaults to false | |||
| pub highlight_code: bool, | |||
| /// Emit either "error" or "warn" for missing highlight languages. Defaults to "warn". | |||
| pub highlight_missing_level: HighlightLanguageLevel, | |||
There was a problem hiding this comment.
I'm wondering if we can just do error_on_unknown_highlight. Do we have anything other than error or warn?
There was a problem hiding this comment.
I was going for symmetry with internal_level in the link checker. I don't have a strong preference.
I suppose we could also have a "do nothing" level, if users are annoyed by the warnings.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a tiny non-breaking feature. I already did the work before seeing the note about your forum in the pull request template. I hope I'm not being too rude by skipping making a post there 😅
Sanity check:
Code changes
(Delete or ignore this section for documentation changes)
nextbranch?If the change is a new feature or adding to/changing an existing one: