Add support for autolinks in safe-settings #212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just to link similar PRs: |
jetersen
approved these changes
May 23, 2022
nitrocode
reviewed
May 24, 2022
| @@ -0,0 +1,69 @@ | |||
| const Diffable = require('./diffable'); | |||
There was a problem hiding this comment.
Should this have a test too to make sure it works in the future ?
|
any word on when this'll be merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes autolinks as a setting the app can handle and manage. If the
autolinksfield is not populated, this is a no-op.Docs about autolinks here https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/managing-repository-settings/configuring-autolinks-to-reference-external-resources
Follows defined "diffable" pattern, so no change really.
Also moved removals of diffs before additions due to bugs with the previous ordering (if you reach max number of autolinks/labels/etc, then adding before removing will cause issues) - removing before adding will "make space" when needed. Not a common issue, but I ran int it while testing