Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Same repository that is part of multiple suborgs #664

Open
wants to merge 5 commits into
base: main-enterprise
Choose a base branch
from

Conversation

decyjphr
Copy link
Collaborator

@decyjphr decyjphr commented Aug 8, 2024

Added code for the following items:

  • Refactoring Sub-Organization Configurations: Throw an error if a repo is found for multiple sub-organizations. Fixes Same repository that is part of multiple suborgs #277
  • Unit Test Enhancements: Added tests for loading and checking suborg configs
  • ESLint config changes

@thebollywoodguy
Copy link

@decyjphr Hi Yadhav.. Looks like this is still in draft. Is it ready to get submitted to merge?

@decyjphr
Copy link
Collaborator Author

@thebollywoodguy I am still working on it. Right now, the issue is if settings.yml or repos/repo.yml is modified, we load all the suborg configs and so we can determine if a repo has multiple suborg configs, but if a single ../suborgs/.yml is modified, we only load that suborg config (for efficiency) and so we cannot determine if the repos for it is also present in other suborg-configs.
So there is some more work remaining to handle that scenario.

@decyjphr decyjphr marked this pull request as ready for review August 29, 2024 21:02
@decyjphr
Copy link
Collaborator Author

@thebollywoodguy this PR is now code complete.

@decyjphr
Copy link
Collaborator Author

@thebollywoodguy I created a release 2.1.12-rc.1 for this PR. If they want to test it from release.

@thebollywoodguy
Copy link

Let me inform the customer. Thank you so much Yadhav

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Same repository that is part of multiple suborgs
2 participants