-
-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make external-types.md compile with gleam 0.3 #263
Conversation
@@ -155,14 +155,14 @@ <h1 id="external-type"><a class="header" href="#external-type">External type</a> | |||
<code>queue</code> module to work with the new <code>Queue</code> type.</p> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I ran make
with mdbook, but my guess is that the version I got is different and made a lot of other changes.
I only accepted the obvious changes.
@external(erlang, "queue" "in") | ||
pub fn push(Queue(a), a) -> Queue(a) | ||
@external(erlang, "queue", "in") | ||
pub fn push(new: a, queue: Queue(a)) -> Queue(a) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Happy to change the name new
here.
0eb0991
to
0c94702
Compare
Closes #256 (I think) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing, thank you!
I looked at the order of
push
and noticed it was wrong. Then, I wanted to play with the example and it didn't compile. This should compile and work now. Unsure if any other changes need to be made.