Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: Add Zoo #422

Open
wants to merge 20 commits into
base: main
Choose a base branch
from
Open

feat!: Add Zoo #422

wants to merge 20 commits into from

Conversation

SilviaZeta
Copy link
Contributor

@SilviaZeta SilviaZeta commented Jun 29, 2022 •
edited
Loading

Description

  • add ZooDialog as prop and place the element inside the UI.
  • add a notepad for entering a plugin's description to CreatePluginDialog and EditPluginDialog.
  • add button for publishing plugins to PluginsView; the button is only for the team's original plugins, not for the ones acquired from other teams.
  • rename and refactor IPlugin interface (now calledPlugin) and export it to re-use it in DOMINATE.
  • fix export issue and the imcompatible types between DOMINATE and MANAGE it discloses.
  • move launchDocs out of the services object and add it as a prop to UserInterface, because the method is not compatible with the Services interface.

relates to gliff-ai/roadmap#82

Checklist:

Put an x in the boxes that apply to this pull request (you can also fill these out after opening the pull request). If you're unsure about any of these, don't hesitate to leave a comment on this pull request!

  • I have read the gliff.ai Contribution Guide.
  • I have requested to pull a branch and not from main.
  • I have checked all commit message styles match the requested structure.
  • My code follows the style guidelines of this project.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have performed a self-review of my own code.
  • I have assigned 3 or less reviewers.
  • New and existing unit tests pass locally with my changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • My changes generate no new warnings.
  • I have made corresponding changes to the documentation.
  • New database changes have been committed.
  • If appropriate, I have bumped any version numbers.

@SilviaZeta SilviaZeta changed the title feat: Add Zoo feat!: Add Zoo Jun 29, 2022
@gliff-ai-robot gliff-ai-robot added feature [Improvement] New feature request. and removed feature [Improvement] New feature request. labels Jun 29, 2022
@SilviaZeta SilviaZeta self-assigned this Jul 12, 2022
@github-actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://ambitious-pond-0d3b89503-422.westeurope.azurestaticapps.net

@SilviaZeta
fix: Interfaces to match data passed by DOMINATE
ceb48c2
@SilviaZeta
fix: pass launchDocs as prop to UserInterface
374f57d 
and launchDocs from Services as it is not compatible with the Services interface
@github-actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://ambitious-pond-0d3b89503-422.westeurope.azurestaticapps.net

@github-actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://ambitious-pond-0d3b89503-422.westeurope.azurestaticapps.net

@github-actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://ambitious-pond-0d3b89503-422.westeurope.azurestaticapps.net

@github-actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://ambitious-pond-0d3b89503-422.westeurope.azurestaticapps.net

@github-actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://ambitious-pond-0d3b89503-422.westeurope.azurestaticapps.net

@github-actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://ambitious-pond-0d3b89503-422.westeurope.azurestaticapps.net

@github-actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://ambitious-pond-0d3b89503-422.westeurope.azurestaticapps.net

@SilviaZeta SilviaZeta mentioned this pull request Jul 18, 2022
Draft
13 tasks
@github-actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://ambitious-pond-0d3b89503-422.westeurope.azurestaticapps.net

ChasNelson1990
ChasNelson1990 previously approved these changes Jul 21, 2022
View reviewed changes
@github-actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://ambitious-pond-0d3b89503-422.westeurope.azurestaticapps.net

@github-actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://ambitious-pond-0d3b89503-422.westeurope.azurestaticapps.net

@SilviaZeta SilviaZeta marked this pull request as ready for review July 29, 2022 10:50
@github-actions
Copy link

github-actions bot commented Aug 1, 2022

Azure Static Web Apps: Your stage site is ready! Visit it here: https://ambitious-pond-0d3b89503-422.westeurope.azurestaticapps.net

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChasNelson1990 ChasNelson1990 ChasNelson1990 approved these changes

@ChrisBaidoo ChrisBaidoo Awaiting requested review from ChrisBaidoo

@joshuajames-smith joshuajames-smith Awaiting requested review from joshuajames-smith

@Kinukeo Kinukeo Awaiting requested review from Kinukeo

@philipjackson philipjackson Awaiting requested review from philipjackson

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SilviaZeta @ChasNelson1990 @gliff-ai-robot