Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

configurable tab label truncation style #220

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rolandwalker
Copy link
Contributor

Choice of Right, Middle, or Left elision to make label text fit on tab GUI element.

Setting only visible in Preferences / Advanced.

Exposing a bare int for the setting is crude. I'm hazily assuming you may add an NSDictionary type to the advanced settings in the future (mapping to a dropdown in the GUI), which could be made backward-compatible to the int value.

Right, Middle, or Left elision to make label text fit on
tab GUI element.
@@ -9,6 +9,7 @@
#import "PSMYosemiteTabStyle.h"
#import "PSMTabBarCell.h"
#import "PSMTabBarControl.h"
#import "iTermAdvancedSettingsModel.h"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't want iTerm code leaking into PSM code. It really should be in a separate target. This should go up the delegate chain, instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants