Display correct window restoration instructions for macOS 14 #500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TL;DR: I believe the "Window Restoration" help window has the outdated text for macOS 14, but not macOS 13. --- I don't have much (any) experience with Objective-C or Apple app dev, so apologies ahead of time if I'm way off base with anything: I noticed on my Mac Book (macOS 14.3 (I know I need to update)) that the "Window Restoration Disabled" window references `System Preferences > General > ...`. Which, based on conditional, should be `Desktop & Dock` for macOS `>=13`. I'm guessing gnachman@f5617a1#diff-3a2c028b85d15b2ff41c606edba92e67d8e1fd252936a12ee185ed859005c809R779 was "reverted" since the message was incorrect for macOS 13, after the change to 14. So I'm further guessing `@available(macOS 13, *)` behaves more like `ver < 14 && ver >= 13.0.0` or `ver ~> 13.0` instead of just `ver >= 13.0.0` or `ver ~> 13`. So I just extended the conditional to `macOS 14` to see if that fixes it. I haven't tried building it myself yet, so sorry for submitting before testing, but hoping to try in the next morning when I have a moment.
|
The existing code handles any version of macOS greater than or equal to 13, so 14 is already included. Are you sure you were testing the latest version of the code when you saw the outdated message? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR: I believe the "Window Restoration" help window has the outdated text for macOS 14, but not macOS 13.
I don't have much (any) experience with Objective-C or Apple app dev, so apologies ahead of time if I'm way off base with anything:
I noticed on my Mac Book (macOS 14.3 (I know I need to update)) that the "Window Restoration Disabled" help window references
System Preferences > General > .... Which, based on conditional, should beDesktop & Dockfor macOS>= 13.I'm guessing f5617a1#diff-3a2c028b85d15b2ff41c606edba92e67d8e1fd252936a12ee185ed859005c809R779 was "reverted" since the message was incorrect for macOS 13, after the change to 14.
So I'm further guessing
@available(macOS 13, *)behaves more likever < 14 && ver >= 13.0.0orver ~> 13.0instead of justver >= 13.0.0orver ~> 13.So I just extended the conditional to include
macOS 14, to see if that fixes it.I haven't tried building it myself yet, so sorry for submitting before testing, but hoping to try in the next morning when I have a moment. But figured on the off-chance the small change is correct, can at least post.