feat(tm2): Add additional unit tests for tm2/pkg/std #2739
+338
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
linhpn99
requested review from
jaekwon,
moul,
piux2 and
zivkovicmilos
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2739 +/- ##
==========================================
+ Coverage 60.44% 60.54% +0.10%
==========================================
Files 563 563
Lines 75159 75159
==========================================
+ Hits 45427 45507 +80
+ Misses 26343 26260 -83
- Partials 3389 3392 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
linhpn99
changed the title
thehowl
reviewed
Sep 20, 2024
| name string | ||
| input string | ||
| expected GasPrice | ||
| hasError bool |
| name string | ||
| input string | ||
| expected []GasPrice | ||
| hasError bool |
| } | ||
| } | ||
|
|
||
| func Test_CountSubKeys(t *testing.T) { |
Comment on lines
+213
to
+215
| signBytes, err := tx.GetSignBytes(chainID, accountNumber, sequence) | ||
| require.NoError(t, err) | ||
| require.NotEmpty(t, signBytes) |
There was a problem hiding this comment.
should be a golden test (match signBytes against a known example output)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add necessary unit tests to increase test coverage for this package
Contributors' checklist...
BREAKING CHANGE: xxxmessage was included in the description